Commit 873cdda1 authored by Bo Liu's avatar Bo Liu Committed by Martin K. Petersen
Browse files

scsi: core: bsg: Remove usage of the deprecated ida_simple_xxx() API 

Use ida_alloc_xxx()/ida_free() instead of
ida_simple_get()/ida_simple_remove().

The latter is deprecated and more verbose.

Link: https://lore.kernel.org/r/20220617020430.2300-1-liubo03@inspur.com


Signed-off-by: default avatarBo Liu <liubo03@inspur.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6e637b72

block/bsg.c

+2 −2
Original line number Diff line number Diff line
@@ -169,7 +169,7 @@ static void bsg_device_release(struct device *dev) 
{

	struct bsg_device *bd = container_of(dev, struct bsg_device, device);



	ida_simple_remove(&bsg_minor_ida, MINOR(bd->device.devt));

	ida_free(&bsg_minor_ida, MINOR(bd->device.devt));

	kfree(bd);

}
@@ -196,7 +196,7 @@ struct bsg_device *bsg_register_queue(struct request_queue *q, 
	bd->queue = q;

	bd->sg_io_fn = sg_io_fn;



	ret = ida_simple_get(&bsg_minor_ida, 0, BSG_MAX_DEVS, GFP_KERNEL);

	ret = ida_alloc_max(&bsg_minor_ida, BSG_MAX_DEVS - 1, GFP_KERNEL);

	if (ret < 0) {

		if (ret == -ENOSPC)

			dev_err(parent, "bsg: too many bsg devices\n");