Commit 87382ead authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Bjorn Helgaas
Browse files

PCI/sysfs: Move declarations to linux/pci.h 

A couple of architectures build the __weak versions of
pci_create_resource_files() and pci_remove_resource_files() but don't
have prototypes for these, which causes warnings:

  drivers/pci/pci-sysfs.c:1253:12: error: no previous prototype for 'pci_create_resource_files' [-Werror=missing-prototypes]
   1253 | int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }
  drivers/pci/pci-sysfs.c:1254:13: error: no previous prototype for 'pci_remove_resource_files' [-Werror=missing-prototypes]
   1254 | void __weak pci_remove_resource_files(struct pci_dev *dev) { return; }

Move the prototypes from alpha architecture into the global header to avoid
these warnings for all of them.

Link: https://lore.kernel.org/r/20230810141947.1236730-5-arnd@kernel.org


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 0e8207f5

arch/alpha/include/asm/pci.h

+0 −3
Original line number Diff line number Diff line
@@ -88,7 +88,4 @@ extern void pci_adjust_legacy_attr(struct pci_bus *bus, 
				   enum pci_mmap_state mmap_type);

#define HAVE_PCI_LEGACY	1



extern int pci_create_resource_files(struct pci_dev *dev);

extern void pci_remove_resource_files(struct pci_dev *dev);



#endif /* __ALPHA_PCI_H */

include/linux/pci.h

+5 −0
Original line number Diff line number Diff line
@@ -2260,6 +2260,11 @@ int pcibios_alloc_irq(struct pci_dev *dev); 
void pcibios_free_irq(struct pci_dev *dev);

resource_size_t pcibios_default_alignment(void);



#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)

extern int pci_create_resource_files(struct pci_dev *dev);

extern void pci_remove_resource_files(struct pci_dev *dev);

#endif



#if defined(CONFIG_PCI_MMCONFIG) || defined(CONFIG_ACPI_MCFG)

void __init pci_mmcfg_early_init(void);

void __init pci_mmcfg_late_init(void);