Unverified Commit 870d72ab authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: cs47l92: Fix event generation for OUT1 demux 



cs47l92_put_demux returns the value of snd_soc_dapm_mux_update_power,
which returns a 1 if a path was found for the kcontrol. This is
obviously different to the expected return a 1 if the control
was updated value. This results in spurious notifications to
user-space. Update the handling to only return a 1 when the value is
changed.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220628153409.3266932-3-ckeepax@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 15b2e5d1

sound/soc/codecs/cs47l92.c

+7 −1
Original line number Diff line number Diff line
@@ -119,7 +119,13 @@ static int cs47l92_put_demux(struct snd_kcontrol *kcontrol, 
end:

	snd_soc_dapm_mutex_unlock(dapm);



	return snd_soc_dapm_mux_update_power(dapm, kcontrol, mux, e, NULL);

	ret = snd_soc_dapm_mux_update_power(dapm, kcontrol, mux, e, NULL);

	if (ret < 0) {

		dev_err(madera->dev, "Failed to update demux power state: %d\n", ret);

		return ret;

	}



	return change;

}



static SOC_ENUM_SINGLE_DECL(cs47l92_outdemux_enum,