Commit 86eed2a1 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: Fix order of freeing resources in pwmchip_remove() 



pwmchip_add() calls of_pwmchip_add() only after adding the chip to
pwm_chips and releasing pwm_lock. So the proper order in
pwmchip_remove() is to call of_pwmchip_remove() before taking the mutex
and removing the chip from pwm_chips. This way pwmchip_remove() releases
the resources in reverse order compared to pwmchip_add() requesting
them.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 387c74e5

drivers/pwm/core.c

+3 −3
Original line number Diff line number Diff line
@@ -318,13 +318,13 @@ void pwmchip_remove(struct pwm_chip *chip) 
{

	pwmchip_sysfs_unexport(chip);



	if (IS_ENABLED(CONFIG_OF))

		of_pwmchip_remove(chip);



	mutex_lock(&pwm_lock);



	list_del_init(&chip->list);



	if (IS_ENABLED(CONFIG_OF))

		of_pwmchip_remove(chip);



	free_pwms(chip);



	mutex_unlock(&pwm_lock);