Commit 86bb2e3d authored Jun 09, 2021 by Hans de Goede

platform/x86: think-lmi: Fix check for admin password being set



tlmi_priv.pwd_admin->password is an array (not a pointer), so the correct
way to check for the password being set is to check for
tlmi_priv.pwd_admin->password[0] != 0.

For the second check, replace the check with checking that auth_str is
set instead.

Cc: Mark Pearson <markpearson@lenovo.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1505158 ("NO_EFFECT")
Fixes: a7314b3b1d8a ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210609151752.156902-1-hdegoede@redhat.com

parent cb58c277

drivers/platform/x86/think-lmi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -537,7 +537,7 @@ static ssize_t current_value_store(struct kobject *kobj,
		p = strchrnul(new_setting, '\n');
		*p = '\0';

		if (tlmi_priv.pwd_admin->valid && tlmi_priv.pwd_admin->password) {
		if (tlmi_priv.pwd_admin->valid && tlmi_priv.pwd_admin->password[0]) {
		auth_str = kasprintf(GFP_KERNEL, "%s,%s,%s;",
		tlmi_priv.pwd_admin->password,
		encoding_options[tlmi_priv.pwd_admin->encoding],
		@@ -563,7 +563,7 @@ static ssize_t current_value_store(struct kobject *kobj,
		if (ret)
		goto out;

		if (tlmi_priv.pwd_admin->valid && tlmi_priv.pwd_admin->password)
		if (auth_str)
		ret = tlmi_save_bios_settings(auth_str);
		else
		ret = tlmi_save_bios_settings("");