Commit 86aeda32 authored by Amit Engel's avatar Amit Engel Committed by Christoph Hellwig
Browse files

nvmet-tcp: fix header digest verification 



Pass the correct length to nvmet_tcp_verify_hdgst, which is the pdu
header length.  This fixes a wrong behaviour where header digest
verification passes although the digest is wrong.

Signed-off-by: default avatarAmit Engel <amit.engel@dell.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent e790de54

drivers/nvme/target/tcp.c

+1 −1
Original line number Diff line number Diff line
@@ -1096,7 +1096,7 @@ static int nvmet_tcp_try_recv_pdu(struct nvmet_tcp_queue *queue) 
	}



	if (queue->hdr_digest &&

	    nvmet_tcp_verify_hdgst(queue, &queue->pdu, queue->offset)) {

	    nvmet_tcp_verify_hdgst(queue, &queue->pdu, hdr->hlen)) {

		nvmet_tcp_fatal_error(queue); /* fatal */

		return -EPROTO;

	}