Commit 8687bf9e authored by Lee Gibson's avatar Lee Gibson Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan 



Function _rtl92e_wx_set_scan calls memcpy without checking the length.
A user could control that length and trigger a buffer overflow.
Fix by checking the length is within the maximum allowed size.

Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLee Gibson <leegib@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210226145157.424065-1-leegib@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d660f4f4

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c

+4 −3
Original line number Diff line number Diff line
@@ -406,9 +406,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev, 
		struct iw_scan_req *req = (struct iw_scan_req *)b;



		if (req->essid_len) {

			ieee->current_network.ssid_len = req->essid_len;

			memcpy(ieee->current_network.ssid, req->essid,

			       req->essid_len);

			int len = min_t(int, req->essid_len, IW_ESSID_MAX_SIZE);



			ieee->current_network.ssid_len = len;

			memcpy(ieee->current_network.ssid, req->essid, len);

		}

	}