Commit 866b7a27 authored by Zheng Yongjun's avatar Zheng Yongjun Committed by Jakub Kicinski
Browse files

net: dsa: felix: fix possible NULL pointer dereference 



As the possible failure of the allocation, kzalloc() may return NULL
pointer.
Therefore, it should be better to check the 'sgi' in order to prevent
the dereference of NULL pointer.

Fixes: 23ae3a78 ("net: dsa: felix: add stream gate settings for psfp").
Signed-off-by: default avatarZheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20220329090800.130106-1-zhengyongjun3@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 77c9387c

drivers/net/dsa/ocelot/felix_vsc9959.c

+4 −0
Original line number Diff line number Diff line
@@ -1928,6 +1928,10 @@ static int vsc9959_psfp_filter_add(struct ocelot *ocelot, int port, 
		case FLOW_ACTION_GATE:

			size = struct_size(sgi, entries, a->gate.num_entries);

			sgi = kzalloc(size, GFP_KERNEL);

			if (!sgi) {

				ret = -ENOMEM;

				goto err;

			}

			vsc9959_psfp_parse_gate(a, sgi);

			ret = vsc9959_psfp_sgi_table_add(ocelot, sgi);

			if (ret) {