Commit 86594f6a authored by Luca Weiss's avatar Luca Weiss Committed by Mauro Carvalho Chehab
Browse files

media: venus: hfi: avoid null dereference in deinit 



If venus_probe fails at pm_runtime_put_sync the error handling first
calls hfi_destroy and afterwards hfi_core_deinit. As hfi_destroy sets
core->ops to NULL, hfi_core_deinit cannot call the core_deinit function
anymore.

Avoid this null pointer derefence by skipping the call when necessary.

Signed-off-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Signed-off-by: default avatarStanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 90307ebe

drivers/media/platform/qcom/venus/hfi.c

+3 −0
Original line number Diff line number Diff line
@@ -104,6 +104,9 @@ int hfi_core_deinit(struct venus_core *core, bool blocking) 
		mutex_lock(&core->lock);

	}



	if (!core->ops)

		goto unlock;



	ret = core->ops->core_deinit(core);



	if (!ret)