Commit 8648c604 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Clean up connector->*_allowed setup 



All the connectors are zero initialized so no need to clear
the *_allowed flags we don't support. Only leave the ones we want
to set. And while at it switch to booleans instead of ints.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220912111814.17466-13-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 6ac2f04b

drivers/gpu/drm/i915/display/icl_dsi.c

+0 −2
Original line number Diff line number Diff line
@@ -2038,8 +2038,6 @@ void icl_dsi_init(struct drm_i915_private *dev_priv) 
			   DRM_MODE_CONNECTOR_DSI);

	drm_connector_helper_add(connector, &gen11_dsi_connector_helper_funcs);

	connector->display_info.subpixel_order = SubPixelHorizontalRGB;

	connector->interlace_allowed = false;

	connector->doublescan_allowed = false;

	intel_connector->get_hw_state = intel_connector_get_hw_state;



	/* attach connector to encoder */

drivers/gpu/drm/i915/display/intel_crt.c

+2 −5
Original line number Diff line number Diff line
@@ -1050,11 +1050,8 @@ void intel_crt_init(struct drm_i915_private *dev_priv) 
	else

		crt->base.pipe_mask = ~0;



	if (DISPLAY_VER(dev_priv) == 2)

		connector->interlace_allowed = 0;

	else

		connector->interlace_allowed = 1;

	connector->doublescan_allowed = 0;

	if (DISPLAY_VER(dev_priv) != 2)

		connector->interlace_allowed = true;



	crt->adpa_reg = adpa_reg;

drivers/gpu/drm/i915/display/intel_dp.c

+0 −1
Original line number Diff line number Diff line
@@ -5411,7 +5411,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port, 


	if (!HAS_GMCH(dev_priv))

		connector->interlace_allowed = true;

	connector->doublescan_allowed = 0;



	intel_connector->polled = DRM_CONNECTOR_POLL_HPD;

drivers/gpu/drm/i915/display/intel_dvo.c

+0 −2
Original line number Diff line number Diff line
@@ -515,8 +515,6 @@ void intel_dvo_init(struct drm_i915_private *dev_priv) 
		drm_connector_helper_add(connector,

					 &intel_dvo_connector_helper_funcs);

		connector->display_info.subpixel_order = SubPixelHorizontalRGB;

		connector->interlace_allowed = false;

		connector->doublescan_allowed = false;



		intel_connector_attach_encoder(intel_connector, intel_encoder);

		if (dvo->type == INTEL_DVO_CHIP_LVDS) {

drivers/gpu/drm/i915/display/intel_hdmi.c

+2 −3
Original line number Diff line number Diff line
@@ -2956,9 +2956,8 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port, 
				    ddc);

	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);



	connector->interlace_allowed = 1;

	connector->doublescan_allowed = 0;

	connector->stereo_allowed = 1;

	connector->interlace_allowed = true;

	connector->stereo_allowed = true;



	if (DISPLAY_VER(dev_priv) >= 10)

		connector->ycbcr_420_allowed = true;