Commit 85ec038b authored by Zheyu Ma's avatar Zheyu Ma Committed by Helge Deller
Browse files

video: fbdev: neofb: Fix the check of 'var->pixclock' 



The previous check against 'var->pixclock' doesn't return -EINVAL when
it equals zero, but the driver uses it again, causing the divide error.

Fix this by returning when 'var->pixclock' is zero.

The following log reveals it:
 divide error: 0000 [#1] PREEMPT SMP KASAN PTI
 RIP: 0010:neofb_set_par+0x190f/0x49a0
 Call Trace:
  <TASK>
  fb_set_var+0x604/0xeb0
  do_fb_ioctl+0x234/0x670
  fb_ioctl+0xdd/0x130
  do_syscall_64+0x3b/0x90

Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 836ffc47

drivers/video/fbdev/neofb.c

+1 −1
Original line number Diff line number Diff line
@@ -585,7 +585,7 @@ neofb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) 


	DBG("neofb_check_var");



	if (var->pixclock && PICOS2KHZ(var->pixclock) > par->maxClock)

	if (!var->pixclock || PICOS2KHZ(var->pixclock) > par->maxClock)

		return -EINVAL;



	/* Is the mode larger than the LCD panel? */