Commit 85eb75c3 authored Apr 16, 2023 by Avraham Stern Committed by Johannes Berg Apr 17, 2023

wifi: iwlwifi: mvm: avoid iterating over an un-initialized list

The initiator smooth list is initialized only in iwl_mvm_up(), but is
cleared in iwl_mvm_mac_stop. This may result in iterating over the
list before it was initialized in case iwl_mvm_up() failed early.
Fix it by moving the list initialization to an earlier stage.

Fixes: b68bd2e3 ("iwlwifi: mvm: Add FTM initiator RTT smoothing logic")
Signed-off-by: Avraham Stern <avraham.stern@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230416154301.b50b1fe9a576.Ie348ffae110612d2e252ac120a3ba0aea063b1b6@changeid

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 66a588bf

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1727,8 +1727,6 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
		iwl_mvm_tas_init(mvm);
		iwl_mvm_leds_sync(mvm);

		iwl_mvm_ftm_initiator_smooth_config(mvm);

		if (fw_has_capa(&mvm->fw->ucode_capa,
		IWL_UCODE_TLV_CAPA_RFIM_SUPPORT)) {
		if (iwl_mvm_eval_dsm_rfi(mvm) == DSM_VALUE_RFI_ENABLE)

+2 −0

Original line number	Diff line number	Diff line
		@@ -1367,6 +1367,8 @@ iwl_op_mode_mvm_start(struct iwl_trans trans, const struct iwl_cfg cfg,
		else
		memset(&mvm->rx_stats, 0, sizeof(struct mvm_statistics_rx));

		iwl_mvm_ftm_initiator_smooth_config(mvm);

		iwl_mvm_init_time_sync(&mvm->time_sync);

		mvm->debugfs_dir = dbgfs_dir;