Commit 85ae42c7 authored by Konstantin Meskhidze's avatar Konstantin Meskhidze Committed by Dave Jiang
Browse files

nvdimm: Fix memleak of pmu attr_groups in unregister_nvdimm_pmu() 



Memory pointed by 'nd_pmu->pmu.attr_groups' is allocated in function
'register_nvdimm_pmu' and is lost after 'kfree(nd_pmu)' call in function
'unregister_nvdimm_pmu'.

Fixes: 0fab1ba6 ("drivers/nvdimm: Add perf interface to expose nvdimm performance stats")
Co-developed-by: default avatarIvanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: default avatarKonstantin Meskhidze <konstantin.meskhidze@huawei.com>
Reviewed-by: default avatarJeff Moyer <jmoyer@redhat.com>
Link: https://lore.kernel.org/r/20230817115945.771826-1-konstantin.meskhidze@huawei.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent feb72e9b

drivers/nvdimm/nd_perf.c

+1 −0
Original line number Diff line number Diff line
@@ -324,6 +324,7 @@ void unregister_nvdimm_pmu(struct nvdimm_pmu *nd_pmu) 
{

	perf_pmu_unregister(&nd_pmu->pmu);

	nvdimm_pmu_free_hotplug_memory(nd_pmu);

	kfree(nd_pmu->pmu.attr_groups);

	kfree(nd_pmu);

}

EXPORT_SYMBOL_GPL(unregister_nvdimm_pmu);