Commit 85784470 authored by Tim Gardner's avatar Tim Gardner Committed by Borislav Petkov
Browse files

x86/smp: Remove unnecessary assignment to local var freq_scale 



Coverity warns of an unused value in arch_scale_freq_tick():

  CID 100778 (#1 of 1): Unused value (UNUSED_VALUE)
  assigned_value: Assigning value 1024ULL to freq_scale here, but that stored
  value is overwritten before it can be used.

It was introduced by commit:

  e2b0d619 ("x86, sched: check for counters overflow in frequency invariant accounting")

Remove the variable initializer.

Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarGiovanni Gherdovich <ggherdovich@suse.cz>
Link: https://lkml.kernel.org/r/20210910184405.24422-1-tim.gardner@canonical.com
parent 6880fa6c

arch/x86/kernel/smpboot.c

+1 −1
Original line number Diff line number Diff line
@@ -2166,7 +2166,7 @@ DEFINE_PER_CPU(unsigned long, arch_freq_scale) = SCHED_CAPACITY_SCALE; 


void arch_scale_freq_tick(void)

{

	u64 freq_scale = SCHED_CAPACITY_SCALE;

	u64 freq_scale;

	u64 aperf, mperf;

	u64 acnt, mcnt;