Commit 85743cea authored by Zhang Changzhong's avatar Zhang Changzhong Committed by David S. Miller
Browse files

net: dnet: remove unused variable 'tx_status 'in dnet_start_xmit() 



Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/dnet.c:510:6: warning:
 variable 'tx_status' set but not used [-Wunused-but-set-variable]
  u32 tx_status, irq_enable;
      ^~~~~~~~~

After commit 47964174 ("dnet: Dave DNET ethernet controller driver
(updated)"), variable 'tx_status' is never used in dnet_start_xmit(),
so removing it to avoid build warning.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0cbe6a8f

drivers/net/ethernet/dnet.c

+4 −4
Original line number Diff line number Diff line
@@ -507,12 +507,12 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) 
{



	struct dnet *bp = netdev_priv(dev);

	u32 tx_status, irq_enable;

	u32 irq_enable;

	unsigned int i, tx_cmd, wrsz;

	unsigned long flags;

	unsigned int *bufp;



	tx_status = dnet_readl(bp, TX_STATUS);

	dnet_readl(bp, TX_STATUS);



	pr_debug("start_xmit: len %u head %p data %p\n",

	       skb->len, skb->head, skb->data);
@@ -520,7 +520,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) 


	spin_lock_irqsave(&bp->lock, flags);



	tx_status = dnet_readl(bp, TX_STATUS);

	dnet_readl(bp, TX_STATUS);



	bufp = (unsigned int *)(((unsigned long) skb->data) & ~0x3UL);

	wrsz = (u32) skb->len + 3;
@@ -542,7 +542,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) 


	if (dnet_readl(bp, TX_FIFO_WCNT) > DNET_FIFO_TX_DATA_AF_TH) {

		netif_stop_queue(dev);

		tx_status = dnet_readl(bp, INTR_SRC);

		dnet_readl(bp, INTR_SRC);

		irq_enable = dnet_readl(bp, INTR_ENB);

		irq_enable |= DNET_INTR_ENB_TX_FIFOAE;

		dnet_writel(bp, irq_enable, INTR_ENB);