Unverified Commit 85373458 authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Mark Brown
Browse files

ASoC: cs35l56: Don't rely on GPIOD_OUT_LOW to set RESET initially low 



The ACPI setting for a GPIO default state has higher priority than the
flag passed to devm_gpiod_get_optional() so ACPI can override the
GPIOD_OUT_LOW. Explicitly set the GPIO low when hard resetting.

Although GPIOD_OUT_LOW can't be relied on this doesn't seem like a
reason to stop passing it to devm_gpiod_get_optional(). So we still pass
it to state our intent, but can deal with it having no effect.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230808164702.21272-3-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ebd0f7b0

sound/soc/codecs/cs35l56.c

+2 −0
Original line number Diff line number Diff line
@@ -1069,6 +1069,8 @@ int cs35l56_common_probe(struct cs35l56_private *cs35l56) 
		return dev_err_probe(cs35l56->base.dev, ret, "Failed to enable supplies\n");



	if (cs35l56->base.reset_gpio) {

		/* ACPI can override GPIOD_OUT_LOW flag so force it to start low */

		gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);

		cs35l56_wait_min_reset_pulse();

		gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 1);

	}