Commit 84f7e0bb authored by kernel test robot's avatar kernel test robot Committed by David S. Miller
Browse files

dsa: fix for_each_child.cocci warnings 



For_each_available_child_of_node should have of_node_put() before
return around line 423.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarJulia Lawall <julia.lawall@inria.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 222722bc

drivers/net/dsa/microchip/ksz_common.c

+3 −1
Original line number Diff line number Diff line
@@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_device *dev, 
				if (of_property_read_u32(port, "reg",

							 &port_num))

					continue;

				if (!(dev->port_mask & BIT(port_num)))

				if (!(dev->port_mask & BIT(port_num))) {

					of_node_put(port);

					return -EINVAL;

				}

				of_get_phy_mode(port,

						&dev->ports[port_num].interface);

			}