Commit 84e00d9b authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

net: convert some netlink netdev iterators to depend on the xarray 



Reap the benefits of easier iteration thanks to the xarray.
Convert just the genetlink ones, those are easier to test.

Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20230726185530.2247698-3-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 759ab1ed

include/linux/netdevice.h

+3 −0
Original line number Diff line number Diff line
@@ -3016,6 +3016,9 @@ extern rwlock_t dev_base_lock; /* Device list lock */ 
			if (netdev_master_upper_dev_get_rcu(slave) == (bond))

#define net_device_entry(lh)	list_entry(lh, struct net_device, dev_list)



#define for_each_netdev_dump(net, d, ifindex)				\

	xa_for_each_start(&(net)->dev_by_index, (ifindex), (d), (ifindex))



static inline struct net_device *next_net_device(struct net_device *dev)

{

	struct list_head *lh;

net/core/netdev-genl.c

+8 −29
Original line number Diff line number Diff line
@@ -101,43 +101,22 @@ int netdev_nl_dev_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb) 
{

	struct net *net = sock_net(skb->sk);

	struct net_device *netdev;

	int idx = 0, s_idx;

	int h, s_h;

	int err;



	s_h = cb->args[0];

	s_idx = cb->args[1];

	int err = 0;



	rtnl_lock();



	for (h = s_h; h < NETDEV_HASHENTRIES; h++, s_idx = 0) {

		struct hlist_head *head;



		idx = 0;

		head = &net->dev_index_head[h];

		hlist_for_each_entry(netdev, head, index_hlist) {

			if (idx < s_idx)

				goto cont;

	for_each_netdev_dump(net, netdev, cb->args[0]) {

		err = netdev_nl_dev_fill(netdev, skb,

					 NETLINK_CB(cb->skb).portid,

					 cb->nlh->nlmsg_seq, 0,

					 NETDEV_CMD_DEV_GET);

		if (err < 0)

			break;

cont:

			idx++;

	}

	}



	rtnl_unlock();



	if (err != -EMSGSIZE)

		return err;



	cb->args[1] = idx;

	cb->args[0] = h;

	cb->seq = net->dev_base_seq;



	return skb->len;

}

net/ethtool/netlink.c

+17 −48
Original line number Diff line number Diff line
@@ -252,8 +252,7 @@ int ethnl_multicast(struct sk_buff *skb, struct net_device *dev) 
 * @ops:        request ops of currently processed message type

 * @req_info:   parsed request header of processed request

 * @reply_data: data needed to compose the reply

 * @pos_hash:   saved iteration position - hashbucket

 * @pos_idx:    saved iteration position - index

 * @pos_ifindex: saved iteration position - ifindex

 *

 * These parameters are kept in struct netlink_callback as context preserved

 * between iterations. They are initialized by ethnl_default_start() and used
@@ -263,8 +262,7 @@ struct ethnl_dump_ctx { 
	const struct ethnl_request_ops	*ops;

	struct ethnl_req_info		*req_info;

	struct ethnl_reply_data		*reply_data;

	int				pos_hash;

	int				pos_idx;

	unsigned long			pos_ifindex;

};



static const struct ethnl_request_ops *
@@ -490,55 +488,27 @@ static int ethnl_default_dumpit(struct sk_buff *skb, 
{

	struct ethnl_dump_ctx *ctx = ethnl_dump_context(cb);

	struct net *net = sock_net(skb->sk);

	int s_idx = ctx->pos_idx;

	int h, idx = 0;

	struct net_device *dev;

	int ret = 0;



	rtnl_lock();

	for (h = ctx->pos_hash; h < NETDEV_HASHENTRIES; h++, s_idx = 0) {

		struct hlist_head *head;

		struct net_device *dev;

		unsigned int seq;



		head = &net->dev_index_head[h];



restart_chain:

		seq = net->dev_base_seq;

		cb->seq = seq;

		idx = 0;

		hlist_for_each_entry(dev, head, index_hlist) {

			if (idx < s_idx)

				goto cont;

	for_each_netdev_dump(net, dev, ctx->pos_ifindex) {

		dev_hold(dev);

		rtnl_unlock();



		ret = ethnl_default_dump_one(skb, dev, ctx, cb);



		rtnl_lock();

		dev_put(dev);

			if (ret < 0) {

				if (ret == -EOPNOTSUPP)

					goto lock_and_cont;



		if (ret < 0 && ret != -EOPNOTSUPP) {

			if (likely(skb->len))

				ret = skb->len;

				goto out;

			}

lock_and_cont:

			rtnl_lock();

			if (net->dev_base_seq != seq) {

				s_idx = idx + 1;

				goto restart_chain;

			break;

		}

cont:

			idx++;

		}



	}

	rtnl_unlock();



out:

	ctx->pos_hash = h;

	ctx->pos_idx = idx;

	nl_dump_check_consistent(cb, nlmsg_hdr(skb));



	return ret;

}
@@ -584,8 +554,7 @@ static int ethnl_default_start(struct netlink_callback *cb) 
	ctx->ops = ops;

	ctx->req_info = req_info;

	ctx->reply_data = reply_data;

	ctx->pos_hash = 0;

	ctx->pos_idx = 0;

	ctx->pos_ifindex = 0;



	return 0;

net/ethtool/tunnels.c

+26 −45
Original line number Diff line number Diff line
@@ -212,8 +212,7 @@ int ethnl_tunnel_info_doit(struct sk_buff *skb, struct genl_info *info) 


struct ethnl_tunnel_info_dump_ctx {

	struct ethnl_req_info	req_info;

	int			pos_hash;

	int			pos_idx;

	unsigned long		ifindex;

};



int ethnl_tunnel_info_start(struct netlink_callback *cb)
@@ -243,34 +242,24 @@ int ethnl_tunnel_info_dumpit(struct sk_buff *skb, struct netlink_callback *cb) 
{

	struct ethnl_tunnel_info_dump_ctx *ctx = (void *)cb->ctx;

	struct net *net = sock_net(skb->sk);

	int s_idx = ctx->pos_idx;

	int h, idx = 0;

	struct net_device *dev;

	int ret = 0;

	void *ehdr;



	rtnl_lock();

	cb->seq = net->dev_base_seq;

	for (h = ctx->pos_hash; h < NETDEV_HASHENTRIES; h++, s_idx = 0) {

		struct hlist_head *head;

		struct net_device *dev;



		head = &net->dev_index_head[h];

		idx = 0;

		hlist_for_each_entry(dev, head, index_hlist) {

			if (idx < s_idx)

				goto cont;



	for_each_netdev_dump(net, dev, ctx->ifindex) {

		ehdr = ethnl_dump_put(skb, cb,

				      ETHTOOL_MSG_TUNNEL_INFO_GET_REPLY);

		if (!ehdr) {

			ret = -EMSGSIZE;

				goto out;

			break;

		}



			ret = ethnl_fill_reply_header(skb, dev, ETHTOOL_A_TUNNEL_INFO_HEADER);

		ret = ethnl_fill_reply_header(skb, dev,

					      ETHTOOL_A_TUNNEL_INFO_HEADER);

		if (ret < 0) {

			genlmsg_cancel(skb, ehdr);

				goto out;

			break;

		}



		ctx->req_info.dev = dev;
@@ -279,21 +268,13 @@ int ethnl_tunnel_info_dumpit(struct sk_buff *skb, struct netlink_callback *cb) 
		if (ret < 0) {

			genlmsg_cancel(skb, ehdr);

			if (ret == -EOPNOTSUPP)

					goto cont;

				goto out;

				continue;

			break;

		}

		genlmsg_end(skb, ehdr);

cont:

			idx++;

	}

	}

out:

	rtnl_unlock();



	ctx->pos_hash = h;

	ctx->pos_idx = idx;

	nl_dump_check_consistent(cb, nlmsg_hdr(skb));



	if (ret == -EMSGSIZE && skb->len)

		return skb->len;

	return ret;