Commit 84c8a874 authored by Maxim Mikityanskiy's avatar Maxim Mikityanskiy Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix division by 0 in mlx5e_select_queue for representors 



Commit 846d6da1 ("net/mlx5e: Fix division by 0 in
mlx5e_select_queue") makes mlx5e_build_nic_params assign a non-zero
initial value to priv->num_tc_x_num_ch, so that mlx5e_select_queue
doesn't fail with division by 0 if called before the first activation of
channels. However, the initialization flow of representors doesn't call
mlx5e_build_nic_params, so this bug can still happen with representors.

This commit fixes the bug by adding the missing assignment to
mlx5e_build_rep_params.

Fixes: 846d6da1 ("net/mlx5e: Fix division by 0 in mlx5e_select_queue")
Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 0bc73ad4

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

+5 −0
Original line number Diff line number Diff line
@@ -618,6 +618,11 @@ static void mlx5e_build_rep_params(struct net_device *netdev) 
	params->mqprio.num_tc       = 1;

	params->tunneled_offload_en = false;



	/* Set an initial non-zero value, so that mlx5e_select_queue won't

	 * divide by zero if called before first activating channels.

	 */

	priv->num_tc_x_num_ch = params->num_channels * params->mqprio.num_tc;



	mlx5_query_min_inline(mdev, &params->tx_min_inline_mode);

}