Commit 84c5aa47 authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: fix credit count leakage 



This patch fix the failure from smb2.credits.single_req_credits_granted
test. When client send 8192 credit request, ksmbd return 8191 credit
granted. ksmbd should give maximum possible credits that must be granted
within the range of not exceeding the max credit to client.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent df14afee

fs/smb/server/smb2pdu.c

+1 −5
Original line number Diff line number Diff line
@@ -326,13 +326,9 @@ int smb2_set_rsp_credits(struct ksmbd_work *work) 
	if (hdr->Command == SMB2_NEGOTIATE)

		aux_max = 1;

	else

		aux_max = conn->vals->max_credits - credit_charge;

		aux_max = conn->vals->max_credits - conn->total_credits;

	credits_granted = min_t(unsigned short, credits_requested, aux_max);



	if (conn->vals->max_credits - conn->total_credits < credits_granted)

		credits_granted = conn->vals->max_credits -

			conn->total_credits;



	conn->total_credits += credits_granted;

	work->credits_granted += credits_granted;