Commit 8491f59e authored by Tong Zhang's avatar Tong Zhang Committed by Takashi Iwai
Browse files

ALSA: vx222: fix null-ptr-deref 



a recent refactor created a null pointer vx in snd_vx222_probe().
The vx pointer should have been populated in snd_vx222_create() as
suggested in earlier version, otherwise vx->core.ibl.size will throw an
error.

[    1.298398] BUG: kernel NULL pointer dereference, address: 00000000000001d8
[    1.316799] RIP: 0010:snd_vx222_probe+0x155/0x290 [snd_vx222]

Fixes: 3bde3359 ("ALSA: vx222: Allocate resources with device-managed APIs")
Signed-off-by: default avatarTong Zhang <ztong0001@gmail.com>
Link: https://lore.kernel.org/r/20210907014746.1445278-1-ztong0001@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c8b177b6

sound/pci/vx222/vx222.c

+1 −0
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ static int snd_vx222_create(struct snd_card *card, struct pci_dev *pci, 
	}

	chip->irq = pci->irq;

	card->sync_irq = chip->irq;

	*rchip = vx;



	return 0;

}