Commit 84762d8d authored by Jimmy Assarsson's avatar Jimmy Assarsson Committed by Marc Kleine-Budde
Browse files

can: kvaser_pciefd: Call request_irq() before enabling interrupts 



Make sure the interrupt handler is registered before enabling interrupts.

Fixes: 26ad340e ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJimmy Assarsson <extja@kvaser.com>
Link: https://lore.kernel.org/r/20230516134318.104279-4-extja@kvaser.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent bf7ac55e

drivers/net/can/kvaser_pciefd.c

+5 −5
Original line number Diff line number Diff line
@@ -1827,6 +1827,11 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev, 
	if (err)

		goto err_teardown_can_ctrls;



	err = request_irq(pcie->pci->irq, kvaser_pciefd_irq_handler,

			  IRQF_SHARED, KVASER_PCIEFD_DRV_NAME, pcie);

	if (err)

		goto err_teardown_can_ctrls;



	iowrite32(KVASER_PCIEFD_SRB_IRQ_DPD0 | KVASER_PCIEFD_SRB_IRQ_DPD1,

		  pcie->reg_base + KVASER_PCIEFD_SRB_IRQ_REG);
@@ -1847,11 +1852,6 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev, 
	iowrite32(KVASER_PCIEFD_SRB_CMD_RDB1,

		  pcie->reg_base + KVASER_PCIEFD_SRB_CMD_REG);



	err = request_irq(pcie->pci->irq, kvaser_pciefd_irq_handler,

			  IRQF_SHARED, KVASER_PCIEFD_DRV_NAME, pcie);

	if (err)

		goto err_teardown_can_ctrls;



	err = kvaser_pciefd_reg_candev(pcie);

	if (err)

		goto err_free_irq;