Commit 845517ed authored by Minghao Chi's avatar Minghao Chi Committed by Jason Gunthorpe
Browse files

RDMA/qedr: Remove unnecessary synchronize_irq() before free_irq() 

Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Link: https://lore.kernel.org/r/20220513081647.1631141-1-chi.minghao@zte.com.cn


Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarMinghao Chi <chi.minghao@zte.com.cn>
Acked-by: default avatarMichal <Kalderon&nbsp;&lt;michal.kalderon@marvell.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 813c9802

drivers/infiniband/hw/qedr/main.c

+0 −1
Original line number Diff line number Diff line
@@ -500,7 +500,6 @@ static void qedr_sync_free_irqs(struct qedr_dev *dev) 
		if (dev->int_info.msix_cnt) {

			idx = i * dev->num_hwfns + dev->affin_hwfn_idx;

			vector = dev->int_info.msix[idx].vector;

			synchronize_irq(vector);

			free_irq(vector, &dev->cnq_array[i]);

		}

	}