Commit 84345c61 authored by Hans de Goede's avatar Hans de Goede Committed by Dmitry Torokhov
Browse files

Input: goodix - improve gpiod_get() error logging 



goodix_get_gpio_config() errors are fatal (abort probe()) so log them
at KERN_ERR level rather then as debug messages.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211212124242.81019-4-hdegoede@redhat.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 5ede7f0c

drivers/input/touchscreen/goodix.c

+2 −2
Original line number Diff line number Diff line
@@ -954,7 +954,7 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts) 
	if (IS_ERR(gpiod)) {

		error = PTR_ERR(gpiod);

		if (error != -EPROBE_DEFER)

			dev_dbg(dev, "Failed to get %s GPIO: %d\n",

			dev_err(dev, "Failed to get %s GPIO: %d\n",

				GOODIX_GPIO_INT_NAME, error);

		return error;

	}
@@ -971,7 +971,7 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts) 
	if (IS_ERR(gpiod)) {

		error = PTR_ERR(gpiod);

		if (error != -EPROBE_DEFER)

			dev_dbg(dev, "Failed to get %s GPIO: %d\n",

			dev_err(dev, "Failed to get %s GPIO: %d\n",

				GOODIX_GPIO_RST_NAME, error);

		return error;

	}