Commit 8416ecfb authored by Yangtao Li's avatar Yangtao Li Committed by Daniel Lezcano
Browse files

thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs() 



Ensure that all error handling branches print error information. In this
way, when this function fails, the upper-layer functions can directly
return an error code without missing debugging information. Otherwise,
the error message will be printed redundantly or missing.

Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230620090732.50025-1-frank.li@vivo.com
parent 2ef95331

drivers/thermal/thermal_hwmon.c

+4 −1
Original line number Diff line number Diff line
@@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device 


	ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr),

			   GFP_KERNEL);

	if (!ptr)

	if (!ptr) {

		dev_warn(dev, "Failed to allocate device resource data\n");

		return -ENOMEM;

	}



	ret = thermal_add_hwmon_sysfs(tz);

	if (ret) {

		dev_warn(dev, "Failed to add hwmon sysfs attributes\n");

		devres_free(ptr);

		return ret;

	}