Commit 84048039 authored by Vlastimil Babka's avatar Vlastimil Babka
Browse files

mm, slub: don't disable irq for debug_check_no_locks_freed() 



In slab_free_hook() we disable irqs around the debug_check_no_locks_freed()
call, which is unnecessary, as irqs are already being disabled inside the call.
This seems to be leftover from the past where there were more calls inside the
irq disabled sections. Remove the irq disable/enable operations.

Mel noted:
> Looks like it was needed for kmemcheck which went away back in 4.15

Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Acked-by: default avatarMel Gorman <mgorman@techsingularity.net>
parent 0a19e7dd

mm/slub.c

+1 −13
Original line number Diff line number Diff line
@@ -1591,20 +1591,8 @@ static __always_inline bool slab_free_hook(struct kmem_cache *s, 
{

	kmemleak_free_recursive(x, s->flags);



	/*

	 * Trouble is that we may no longer disable interrupts in the fast path

	 * So in order to make the debug calls that expect irqs to be

	 * disabled we need to disable interrupts temporarily.

	 */

#ifdef CONFIG_LOCKDEP

	{

		unsigned long flags;



		local_irq_save(flags);

	debug_check_no_locks_freed(x, s->object_size);

		local_irq_restore(flags);

	}

#endif



	if (!(s->flags & SLAB_DEBUG_OBJECTS))

		debug_check_no_obj_freed(x, s->object_size);