Commit 83eb4868 authored by Yu Kuai's avatar Yu Kuai Committed by Vinod Koul
Browse files

dmaengine: stm32-mdma: fix PM reference leak in stm32_mdma_alloc_chan_resourc() 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20210517081826.1564698-2-yukuai3@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8982d48a

drivers/dma/stm32-mdma.c

+2 −2
Original line number Diff line number Diff line
@@ -1452,7 +1452,7 @@ static int stm32_mdma_alloc_chan_resources(struct dma_chan *c) 
		return -ENOMEM;

	}



	ret = pm_runtime_get_sync(dmadev->ddev.dev);

	ret = pm_runtime_resume_and_get(dmadev->ddev.dev);

	if (ret < 0)

		return ret;
@@ -1718,7 +1718,7 @@ static int stm32_mdma_pm_suspend(struct device *dev) 
	u32 ccr, id;

	int ret;



	ret = pm_runtime_get_sync(dev);

	ret = pm_runtime_resume_and_get(dev);

	if (ret < 0)

		return ret;