Commit 83d8909d authored by Colin Ian King's avatar Colin Ian King Committed by Xiaolong Wang
Browse files

powercap: intel_rapl: remove redundant store to value after multiply 

mainline inclusion
from mainline-v5.19-rc1
commit 59cafa72
category: feature
bugzilla: https://gitee.com/openeuler/intel-kernel/issues/I92135

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=59cafa728c373551423d67a1369289a717006a4b



--------------------------------

There is no need to store the result of the multiply back to variable value
after the multiplication. The store is redundant, replace *= with just *.

Cleans up clang scan build warning:
warning: Although the value stored to 'value' is used in the enclosing
expression, the value is never actually read from 'value'
[deadcode.DeadStores]

Intel-SIG: commit 59cafa72 powercap: intel_rapl: remove redundant store to value after multiply
Backport a dependency of Intel RAPL driver support on TPMI.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
[ Xiaolong Wang: amend commit log ]
Signed-off-by: default avatarXiaolong Wang <xiaolong.wang@intel.com>
parent 581bc989

drivers/powercap/intel_rapl_common.c

+1 −1
Original line number Diff line number Diff line
@@ -1044,7 +1044,7 @@ static u64 rapl_compute_time_window_atom(struct rapl_package *rp, u64 value, 
	 * where time_unit is default to 1 sec. Never 0.

	 */

	if (!to_raw)

		return (value) ? value *= rp->time_unit : rp->time_unit;

		return (value) ? value * rp->time_unit : rp->time_unit;



	value = div64_u64(value, rp->time_unit);