Commit 83c5688b authored by yangerkun's avatar yangerkun Committed by Theodore Ts'o
Browse files

ext4: correct the left/middle/right debug message for binsearch 

The debuginfo for binsearch want to show the left/middle/right extent
while the process search for the goal block. However we show this info
after we change right or left.

Link: https://lore.kernel.org/r/20210903062748.4118886-2-yangerkun@huawei.com


Signed-off-by: default avataryangerkun <yangerkun@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 39fec688

fs/ext4/extents.c

+8 −6
Original line number Diff line number Diff line
@@ -714,13 +714,14 @@ ext4_ext_binsearch_idx(struct inode *inode, 
	r = EXT_LAST_INDEX(eh);

	while (l <= r) {

		m = l + (r - l) / 2;

		ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,

			  le32_to_cpu(l->ei_block), m, le32_to_cpu(m->ei_block),

			  r, le32_to_cpu(r->ei_block));



		if (block < le32_to_cpu(m->ei_block))

			r = m - 1;

		else

			l = m + 1;

		ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,

			  le32_to_cpu(l->ei_block), m, le32_to_cpu(m->ei_block),

			  r, le32_to_cpu(r->ei_block));

	}



	path->p_idx = l - 1;
@@ -782,13 +783,14 @@ ext4_ext_binsearch(struct inode *inode, 


	while (l <= r) {

		m = l + (r - l) / 2;

		ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,

			  le32_to_cpu(l->ee_block), m, le32_to_cpu(m->ee_block),

			  r, le32_to_cpu(r->ee_block));



		if (block < le32_to_cpu(m->ee_block))

			r = m - 1;

		else

			l = m + 1;

		ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,

			  le32_to_cpu(l->ee_block), m, le32_to_cpu(m->ee_block),

			  r, le32_to_cpu(r->ee_block));

	}



	path->p_ext = l - 1;