Commit 83714dc3 authored by Kalesh AP's avatar Kalesh AP Committed by Jakub Kicinski
Browse files

bnxt_en: Fix reporting of test result in ethtool selftest 



When the selftest command fails, driver is not reporting the failure
by updating the "test->flags" when bnxt_close_nic() fails.

Fixes: eb513658 ("bnxt_en: Add basic ethtool -t selftest support.")
Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c5cff16f

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+1 −0
Original line number Diff line number Diff line
@@ -3738,6 +3738,7 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest, 
		bnxt_ulp_stop(bp);

		rc = bnxt_close_nic(bp, true, false);

		if (rc) {

			etest->flags |= ETH_TEST_FL_FAILED;

			bnxt_ulp_start(bp, rc);

			return;

		}