Commit 834c5cf2 authored Jun 23, 2021 by Om Prakash Singh Committed by Lorenzo Pieralisi Aug 04, 2021

PCI: tegra194: Disable interrupts before entering L2

In suspend_noirq() call if link doesn't goto L2, PERST# is asserted
to bring link to detect state. However, this is causing surprise
link down AER error. Since Kernel is executing noirq suspend calls,
AER interrupt is not processed. PME and AER are shared interrupts
and PCIe subsystem driver enables wake capability of PME irq during
suspend. So this AER will cause suspend failure due to pending
AER interrupt.

After PCIe link is in L2, interrupts are not expected since PCIe
controller will be in reset state. Disable PCIe interrupts before
going to L2 state to avoid pending AER interrupt.

Link: https://lore.kernel.org/r/20210623100525.19944-4-omp@nvidia.com


Signed-off-by: Om Prakash Singh <omp@nvidia.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Vidya Sagar <vidyas@nvidia.com>

parent 43537cf7

drivers/pci/controller/dwc/pcie-tegra194.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -1493,6 +1493,16 @@ static void tegra_pcie_dw_pme_turnoff(struct tegra_pcie_dw *pcie)
		return;
		}

		/*
		* PCIe controller exits from L2 only if reset is applied, so
		* controller doesn't handle interrupts. But in cases where
		* L2 entry fails, PERST# is asserted which can trigger surprise
		* link down AER. However this function call happens in
		* suspend_noirq(), so AER interrupt will not be processed.
		* Disable all interrupts to avoid such a scenario.
		*/
		appl_writel(pcie, 0x0, APPL_INTR_EN_L0_0);

		if (tegra_pcie_try_link_l2(pcie)) {
		dev_info(pcie->dev, "Link didn't transition to L2 state\n");
		/*