Unverified Commit 8311ee21 authored by Dongliang Mu's avatar Dongliang Mu Committed by Mark Brown
Browse files

spi: meson-spicc: fix memory leak in meson_spicc_remove 



In meson_spicc_probe, the error handling code needs to clean up master
by calling spi_master_put, but the remove function does not have this
function call. This will lead to memory leak of spicc->master.

Reported-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Fixes: 454fa271("spi: Add Meson SPICC driver")
Signed-off-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20210720100116.1438974-1-mudongliangabcd@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1d5ccab9

drivers/spi/spi-meson-spicc.c

+2 −0
Original line number Diff line number Diff line
@@ -785,6 +785,8 @@ static int meson_spicc_remove(struct platform_device *pdev) 
	clk_disable_unprepare(spicc->core);

	clk_disable_unprepare(spicc->pclk);



	spi_master_put(spicc->master);



	return 0;

}