Commit 83114df3 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Jens Axboe
Browse files

block: fix memory leak in disk_register_independent_access_ranges 



kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix this issue by adding kobject_put().
Callback function blk_ia_ranges_sysfs_release() in kobject_put()
can handle the pointer "iars" properly.

Fixes: a2247f19 ("block: Add independent access ranges support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Link: https://lore.kernel.org/r/20220120101025.22411-1-linmq006@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent dd81e1c7

block/blk-ia-ranges.c

+1 −1
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ int disk_register_independent_access_ranges(struct gendisk *disk, 
				   &q->kobj, "%s", "independent_access_ranges");

	if (ret) {

		q->ia_ranges = NULL;

		kfree(iars);

		kobject_put(&iars->kobj);

		return ret;

	}