Commit 8306d6f3 authored by Zev Weiss's avatar Zev Weiss Committed by Greg Kroah-Hartman
Browse files

peci: Constify struct peci_controller_ops 



As with most ops structs, we never modify it at runtime, and keeping
function pointers in read-only memory is generally a good thing
security-wise.

Signed-off-by: default avatarZev Weiss <zev@bewilderbeest.net>
Link: https://lore.kernel.org/r/20230327224315.11135-1-zev@bewilderbeest.net


Reviewed-by: default avatarIwona Winiarska <iwona.winiarska@intel.com>
Signed-off-by: default avatarIwona Winiarska <iwona.winiarska@intel.com>
Link: https://lore.kernel.org/r/20230623142805.577612-1-iwona.winiarska@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a436194d

drivers/peci/controller/peci-aspeed.c

+1 −1
Original line number Diff line number Diff line
@@ -468,7 +468,7 @@ static void aspeed_peci_property_setup(struct aspeed_peci *priv) 
				      ASPEED_PECI_CMD_TIMEOUT_MS_DEFAULT, &priv->cmd_timeout_ms);

}



static struct peci_controller_ops aspeed_ops = {

static const struct peci_controller_ops aspeed_ops = {

	.xfer = aspeed_peci_xfer,

};

drivers/peci/core.c

+2 −2
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ int peci_controller_scan_devices(struct peci_controller *controller) 
}



static struct peci_controller *peci_controller_alloc(struct device *dev,

						     struct peci_controller_ops *ops)

						     const struct peci_controller_ops *ops)

{

	struct peci_controller *controller;

	int ret;
@@ -113,7 +113,7 @@ static void unregister_controller(void *_controller) 
 * Return: Pointer to the newly allocated controller or ERR_PTR() in case of failure.

 */

struct peci_controller *devm_peci_controller_add(struct device *dev,

						 struct peci_controller_ops *ops)

						 const struct peci_controller_ops *ops)

{

	struct peci_controller *controller;

	int ret;

include/linux/peci.h

+2 −2
Original line number Diff line number Diff line
@@ -42,13 +42,13 @@ struct peci_controller_ops { 
 */

struct peci_controller {

	struct device dev;

	struct peci_controller_ops *ops;

	const struct peci_controller_ops *ops;

	struct mutex bus_lock; /* held for the duration of xfer */

	u8 id;

};



struct peci_controller *devm_peci_controller_add(struct device *parent,

						 struct peci_controller_ops *ops);

						 const struct peci_controller_ops *ops);



static inline struct peci_controller *to_peci_controller(void *d)

{