Commit 8304cf77 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: firewire-lib: fix invalid assignment to union data for directional parameter 



Although the value of FDF is used just for outgoing stream, the assignment
to union member is done for both directions of stream. At present this
causes no issue because the value of same position is reassigned later for
opposite stream. However, it's better to add if statement.

Fixes: d3d10a4a ("ALSA: firewire-lib: use union for directional parameters")
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20200508043635.349339-2-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 89ebe49a

sound/firewire/amdtp-am824.c

+2 −1
Original line number Diff line number Diff line
@@ -82,6 +82,7 @@ int amdtp_am824_set_parameters(struct amdtp_stream *s, unsigned int rate, 
	if (err < 0)

		return err;



	if (s->direction == AMDTP_OUT_STREAM)

		s->ctx_data.rx.fdf = AMDTP_FDF_AM824 | s->sfc;



	p->pcm_channels = pcm_channels;