Commit 82ebbe65 authored by Manank Patel's avatar Manank Patel Committed by Wim Van Sebroeck
Browse files

drivers: watchdog: exar_wdt.c fix use after free



fix use after free by storing the result of PTR_ERR(n->pdev)
to a local variable before returning.

Signed-off-by: default avatarManank Patel <pmanank200502@gmail.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20221013095258.1424967-1-pmanank200502@gmail.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 097a4a16
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -355,8 +355,10 @@ static int __init exar_wdt_register(struct wdt_priv *priv, const int idx)
						    &priv->wdt_res, 1,
						    priv, sizeof(*priv));
	if (IS_ERR(n->pdev)) {
		int err = PTR_ERR(n->pdev);

		kfree(n);
		return PTR_ERR(n->pdev);
		return err;
	}

	list_add_tail(&n->list, &pdev_list);