Unverified Commit 82cca659 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!14546 media: wl128x: Fix atomicity violation in fmc_send_cmd() 

Merge Pull Request from: @ci-robot 
 
PR sync from: dinglongwei <dinglongwei1@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/LOTH455JNFKK72EXOZ7EYRHPTF6DTF7R/ 
 
https://gitee.com/src-openeuler/kernel/issues/IBEDOW 
 
Link:https://gitee.com/openeuler/kernel/pulls/14546

 

Reviewed-by: default avatarLiu YongQiang <liuyongqiang13@huawei.com>
Signed-off-by: default avatarZhang Peng <zhangpeng362@huawei.com>
parents 605e322c 349f4c31

drivers/media/radio/wl128x/fmdrv_common.c

+2 −1
Original line number Diff line number Diff line
@@ -466,11 +466,12 @@ int fmc_send_cmd(struct fmdev *fmdev, u8 fm_op, u16 type, void *payload, 
			   jiffies_to_msecs(FM_DRV_TX_TIMEOUT) / 1000);

		return -ETIMEDOUT;

	}

	spin_lock_irqsave(&fmdev->resp_skb_lock, flags);

	if (!fmdev->resp_skb) {

		spin_unlock_irqrestore(&fmdev->resp_skb_lock, flags);

		fmerr("Response SKB is missing\n");

		return -EFAULT;

	}

	spin_lock_irqsave(&fmdev->resp_skb_lock, flags);

	skb = fmdev->resp_skb;

	fmdev->resp_skb = NULL;

	spin_unlock_irqrestore(&fmdev->resp_skb_lock, flags);