Commit 82c66d2b authored Jun 20, 2022 by Christian Marangi Committed by Chanwoo Choi Jun 30, 2022

PM / devfreq: Fix kernel warning with cpufreq passive register fail



Remove cpufreq_passive_unregister_notifier from
cpufreq_passive_register_notifier in case of error as devfreq core
already call unregister on GOV_START fail.

This fix the kernel always printing a WARN on governor PROBE_DEFER as
cpufreq_passive_unregister_notifier is called two times and return
error on the second call as the cpufreq is already unregistered.

Fixes: a03dacb0 ("PM / devfreq: Add cpu based scaling support to passive governor")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

parent b5d281f6

drivers/devfreq/governor_passive.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -330,7 +330,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
		err_put_policy:
		cpufreq_cpu_put(policy);
		err:
		WARN_ON(cpufreq_passive_unregister_notifier(devfreq));

		return ret;
		}