Commit 82c416b1 authored by Christian König's avatar Christian König Committed by Alex Deucher
Browse files

drm/amdgpu: fix and cleanup amdgpu_gem_object_close v4 



The problem is that we can't add the clear fence to the BO
when there is an exclusive fence on it since we can't
guarantee the the clear fence will complete after the
exclusive one.

To fix this refactor the function and also add the exclusive
fence as shared to the resv object.

v2: fix warning
v3: add excl fence as shared instead
v4: squash in fix for fence handling in amdgpu_gem_object_close

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarxinhui pan <xinhui.pan@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9ec420d8

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+25 −18
Original line number Diff line number Diff line
@@ -161,16 +161,17 @@ void amdgpu_gem_object_close(struct drm_gem_object *obj, 


	struct amdgpu_bo_list_entry vm_pd;

	struct list_head list, duplicates;

	struct dma_fence *fence = NULL;

	struct ttm_validate_buffer tv;

	struct ww_acquire_ctx ticket;

	struct amdgpu_bo_va *bo_va;

	int r;

	long r;



	INIT_LIST_HEAD(&list);

	INIT_LIST_HEAD(&duplicates);



	tv.bo = &bo->tbo;

	tv.num_shared = 1;

	tv.num_shared = 2;

	list_add(&tv.head, &list);



	amdgpu_vm_get_pd_bo(vm, &list, &vm_pd);
@@ -178,28 +179,34 @@ void amdgpu_gem_object_close(struct drm_gem_object *obj, 
	r = ttm_eu_reserve_buffers(&ticket, &list, false, &duplicates);

	if (r) {

		dev_err(adev->dev, "leaking bo va because "

			"we fail to reserve bo (%d)\n", r);

			"we fail to reserve bo (%ld)\n", r);

		return;

	}

	bo_va = amdgpu_vm_bo_find(vm, bo);

	if (bo_va && --bo_va->ref_count == 0) {

	if (!bo_va || --bo_va->ref_count)

		goto out_unlock;



	amdgpu_vm_bo_rmv(adev, bo_va);

	if (!amdgpu_vm_ready(vm))

		goto out_unlock;



		if (amdgpu_vm_ready(vm)) {

			struct dma_fence *fence = NULL;

	fence = dma_resv_get_excl(bo->tbo.base.resv);

	if (fence) {

		amdgpu_bo_fence(bo, fence, true);

		fence = NULL;

	}



	r = amdgpu_vm_clear_freed(adev, vm, &fence);

			if (unlikely(r)) {

				dev_err(adev->dev, "failed to clear page "

					"tables on GEM object close (%d)\n", r);

			}

	if (r || !fence)

		goto out_unlock;



			if (fence) {

	amdgpu_bo_fence(bo, fence, true);

	dma_fence_put(fence);

			}

		}

	}



out_unlock:

	if (unlikely(r < 0))

		dev_err(adev->dev, "failed to clear page "

			"tables on GEM object close (%ld)\n", r);

	ttm_eu_backoff_reservation(&ticket, &list);

}