Commit 82ab2b52 authored by Mustafa Ismail's avatar Mustafa Ismail Committed by Leon Romanovsky
Browse files

RDMA/irdma: Fix VLAN connection with wildcard address 

When an application listens on a wildcard address, and there are VLAN and
non-VLAN IP addresses, iWARP connection establishemnt can fail if the listen
node VLAN ID does not match.

Fix this by checking the vlan_id only if not a wildcard listen node.

Fixes: 146b9756 ("RDMA/irdma: Add connection manager")
Link: https://lore.kernel.org/r/20220705230815.265-7-shiraz.saleem@intel.com


Signed-off-by: default avatarMustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 8ecef789

drivers/infiniband/hw/irdma/cm.c

+6 −5
Original line number Diff line number Diff line
@@ -1477,12 +1477,13 @@ irdma_find_listener(struct irdma_cm_core *cm_core, u32 *dst_addr, u16 dst_port, 
	list_for_each_entry (listen_node, &cm_core->listen_list, list) {

		memcpy(listen_addr, listen_node->loc_addr, sizeof(listen_addr));

		listen_port = listen_node->loc_port;

		if (listen_port != dst_port ||

		    !(listener_state & listen_node->listener_state))

			continue;

		/* compare node pair, return node handle if a match */

		if ((!memcmp(listen_addr, dst_addr, sizeof(listen_addr)) ||

		     !memcmp(listen_addr, ip_zero, sizeof(listen_addr))) &&

		    listen_port == dst_port &&

		    vlan_id == listen_node->vlan_id &&

		    (listener_state & listen_node->listener_state)) {

		if (!memcmp(listen_addr, ip_zero, sizeof(listen_addr)) ||

		    (!memcmp(listen_addr, dst_addr, sizeof(listen_addr)) &&

		     vlan_id == listen_node->vlan_id)) {

			refcount_inc(&listen_node->refcnt);

			spin_unlock_irqrestore(&cm_core->listen_list_lock,

					       flags);