Commit 8220a118 authored Jul 07, 2021 by Paul E. McKenney

torture: Don't redirect qemu-cmd comment lines

Currently, kvm-test-1-run-qemu.sh applies redirection to each and every
line of each qemu-cmd script. Only the first line (the only one that
is not a bash comment) needs to be redirected. Although redirecting
the comments is currently harmless, just adding to the comment, it is
an accident waiting to happen. This commit therefore adjusts the "sed"
command to redirect only the qemu-system* command itself.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent cdeef67d

tools/testing/selftests/rcutorture/bin/kvm-test-1-run-qemu.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -40,7 +40,7 @@ grep '^#' $resdir/qemu-cmd \| sed -e 's/^# //' > $T/qemu-cmd-settings
		. $T/qemu-cmd-settings

		# Decorate qemu-cmd with redirection, backgrounding, and PID capture
		sed -e 's/$/ 2>\&1 \&/' < $resdir/qemu-cmd > $T/qemu-cmd
		sed -e 's/^[^#].*$/& 2>\&1 \&/' < $resdir/qemu-cmd > $T/qemu-cmd
		echo 'echo $! > $resdir/qemu_pid' >> $T/qemu-cmd

		# In case qemu refuses to run...