Commit 81edd471 authored by Fabio Estevam's avatar Fabio Estevam Committed by Bjorn Helgaas
Browse files

PCI: rockchip: Fix platform_get_irq() error handling 



When platform_get_irq() fails we should propagate the real error value
instead of always returning -EINVAL.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>
parent cecaf5cd

drivers/pci/host/pcie-rockchip.c

+3 −3
Original line number Diff line number Diff line
@@ -962,7 +962,7 @@ static int rockchip_pcie_setup_irq(struct rockchip_pcie *rockchip) 
	irq = platform_get_irq_byname(pdev, "sys");

	if (irq < 0) {

		dev_err(dev, "missing sys IRQ resource\n");

		return -EINVAL;

		return irq;

	}



	err = devm_request_irq(dev, irq, rockchip_pcie_subsys_irq_handler,
@@ -975,7 +975,7 @@ static int rockchip_pcie_setup_irq(struct rockchip_pcie *rockchip) 
	irq = platform_get_irq_byname(pdev, "legacy");

	if (irq < 0) {

		dev_err(dev, "missing legacy IRQ resource\n");

		return -EINVAL;

		return irq;

	}



	irq_set_chained_handler_and_data(irq,
@@ -985,7 +985,7 @@ static int rockchip_pcie_setup_irq(struct rockchip_pcie *rockchip) 
	irq = platform_get_irq_byname(pdev, "client");

	if (irq < 0) {

		dev_err(dev, "missing client IRQ resource\n");

		return -EINVAL;

		return irq;

	}



	err = devm_request_irq(dev, irq, rockchip_pcie_client_irq_handler,