Commit 81d0ec43 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Takashi Iwai
Browse files

ALSA: hda: Use DIV_ROUND_UP()/roundup() instead of open-coding it 



Use DIV_ROUND_UP() and roundup() instead of open-coding them. This
documents intent and makes it more clear what is going on for the casual
reviewer.

Generated using the following the Coccinelle semantic patch.

// <smpl>
@@
expression x, y;
@@
-((((x) + (y) - 1) / (y)) * y)
+roundup(x, y)

@r1@
expression x;
constant C1;
constant C2;
@@
 (x + C1) / C2

@script:python@
C1 << r1.C1;
C2 << r1.C2;
@@
print C1, C2
try:
	if int(C1) != int(C2) - 1:
		cocci.include_match(False)
except:
	cocci.include_match(False)

@@
expression r1.x;
constant r1.C1;
constant r1.C2;
@@
-(((x) + C1) / C2)
+DIV_ROUND_UP(x, C2)
// </smpl>

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201223172229.781-9-lars@metafoo.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 483548a2

sound/hda/hdac_stream.c

+2 −3
Original line number Diff line number Diff line
@@ -435,12 +435,11 @@ int snd_hdac_stream_setup_periods(struct hdac_stream *azx_dev) 
	pos_adj = bus->bdl_pos_adj;

	if (!azx_dev->no_period_wakeup && pos_adj > 0) {

		pos_align = pos_adj;

		pos_adj = (pos_adj * runtime->rate + 47999) / 48000;

		pos_adj = DIV_ROUND_UP(pos_adj * runtime->rate, 48000);

		if (!pos_adj)

			pos_adj = pos_align;

		else

			pos_adj = ((pos_adj + pos_align - 1) / pos_align) *

				pos_align;

			pos_adj = roundup(pos_adj, pos_align);

		pos_adj = frames_to_bytes(runtime, pos_adj);

		if (pos_adj >= period_bytes) {

			dev_warn(bus->dev, "Too big adjustment %d\n",