Commit 81cdedb0 authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Mauro Carvalho Chehab
Browse files

media: staging: rkisp1: cap: change RGB24 format to XBGR32 



According to the TRM [1], the YUV->RGB conversion outputs
RGB 888 format with 4 bytes, where the last byte is ignored,
using big endian representation:

|___X___|___R___|___G___|___B___|
31      24      16      8       0

Which matches format V4L2_PIX_FMT_XBGR32 in little endian
representation, so replace it accordingly.

"24 bit word". What it means is that 4 bytes are used with
24bit for the RGB and the last byte is ignored.
This matches format V4L2_PIX_FMT_XBGR32.

Signed-off-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: default avatarHelen Koike <helen.koike@collabora.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 57cc666d

drivers/staging/media/rkisp1/rkisp1-capture.c

+1 −1
Original line number Diff line number Diff line
@@ -276,7 +276,7 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { 
	},

	/* rgb */

	{

		.fourcc = V4L2_PIX_FMT_RGB24,

		.fourcc = V4L2_PIX_FMT_XBGR32,

		.write_format = RKISP1_MI_CTRL_SP_WRITE_PLA,

		.output_format = RKISP1_MI_CTRL_SP_OUTPUT_RGB888,

	}, {