Commit 81c8bf91 authored by Tom Rix's avatar Tom Rix Committed by Jiri Kosina
Browse files

HID: logitech-hidpp: initialize level variable 



Static analysis reports this representative problem

hid-logitech-hidpp.c:1356:23: warning: Assigned value is
  garbage or undefined
        hidpp->battery.level = level;
                             ^ ~~~~~

In some cases, 'level' is never set in hidpp20_battery_map_status_voltage()
Since level is not available on all hw, initialize level to unknown.

Fixes: be281368 ("hid-logitech-hidpp: read battery voltage from newer devices")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarFilipe Laíns <lains@riseup.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 31a4cf1d

drivers/hid/hid-logitech-hidpp.c

+1 −0
Original line number Diff line number Diff line
@@ -1263,6 +1263,7 @@ static int hidpp20_battery_map_status_voltage(u8 data[3], int *voltage, 
	int status;



	long flags = (long) data[2];

	*level = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN;



	if (flags & 0x80)

		switch (flags & 0x07) {