Unverified Commit 81aad472 authored by Yufen Yu's avatar Yufen Yu Committed by Mark Brown
Browse files

ASoC: img: Fix PM reference leak in img_i2s_in_probe() 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYufen Yu <yuyufen@huawei.com>
Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 28b17011

sound/soc/img/img-i2s-in.c

+1 −1
Original line number Diff line number Diff line
@@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev) 
		if (ret)

			goto err_pm_disable;

	}

	ret = pm_runtime_get_sync(&pdev->dev);

	ret = pm_runtime_resume_and_get(&pdev->dev);

	if (ret < 0)

		goto err_suspend;