Commit 819fb78f authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller
Browse files

net: ks8851: Make ks8851_read_selftest() return void 



clang points out that ret in ks8851_read_selftest() is set but unused:

drivers/net/ethernet/micrel/ks8851_common.c:1028:6: warning: variable
'ret' set but not used [-Wunused-but-set-variable]
        int ret = 0;
            ^
1 warning generated.

The return code of this function has never been checked so just remove
ret and make the function return void.

Fixes: 3ba81f3e ("net: Micrel KS8851 SPI network driver")
Suggested-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a10541f5

drivers/net/ethernet/micrel/ks8851_common.c

+4 −11
Original line number Diff line number Diff line
@@ -1022,30 +1022,23 @@ static int ks8851_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) 
 *

 * Read and check the TX/RX memory selftest information.

 */

static int ks8851_read_selftest(struct ks8851_net *ks)

static void ks8851_read_selftest(struct ks8851_net *ks)

{

	unsigned both_done = MBIR_TXMBF | MBIR_RXMBF;

	int ret = 0;

	unsigned rd;



	rd = ks8851_rdreg16(ks, KS_MBIR);



	if ((rd & both_done) != both_done) {

		netdev_warn(ks->netdev, "Memory selftest not finished\n");

		return 0;

		return;

	}



	if (rd & MBIR_TXMBFA) {

	if (rd & MBIR_TXMBFA)

		netdev_err(ks->netdev, "TX memory selftest fail\n");

		ret |= 1;

	}



	if (rd & MBIR_RXMBFA) {

	if (rd & MBIR_RXMBFA)

		netdev_err(ks->netdev, "RX memory selftest fail\n");

		ret |= 2;

	}



	return 0;

}



/* driver bus management functions */