Commit 819cf655 authored by Youling Tang's avatar Youling Tang Committed by Huacai Chen
Browse files

LoongArch: ftrace: Fix build error if DYNAMIC_FTRACE_WITH_REGS is not set 



We can see the following build error if CONFIG_DYNAMIC_FTRACE_WITH_REGS
is not set on LoongArch:

arch/loongarch/kernel/ftrace_dyn.c: In function ‘ftrace_make_call’:
arch/loongarch/kernel/ftrace_dyn.c:167:23: error: implicit declaration of function ‘__get_mod’
  167 |                 ret = __get_mod(&mod, pc);
      |                       ^~~~~~~~~
arch/loongarch/kernel/ftrace_dyn.c:171:24: error: implicit declaration of function ‘get_plt_addr’
  171 |                 addr = get_plt_addr(mod, addr);
      |                        ^~~~~~~~~~~~

The reason is that the __get_mod() and get_plt_addr() may be called in
ftrace_make_{call,nop}.

Signed-off-by: default avatarYouling Tang <tangyouling@loongson.cn>
Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
parent 6fbff14a

arch/loongarch/kernel/ftrace_dyn.c

+1 −3
Original line number Diff line number Diff line
@@ -30,8 +30,6 @@ static int ftrace_modify_code(unsigned long pc, u32 old, u32 new, bool validate) 
	return 0;

}



#ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS



#ifdef CONFIG_MODULES

static inline int __get_mod(struct module **mod, unsigned long addr)

{
@@ -72,6 +70,7 @@ static unsigned long get_plt_addr(struct module *mod, unsigned long addr) 
}

#endif



#ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS

int ftrace_modify_call(struct dyn_ftrace *rec, unsigned long old_addr, unsigned long addr)

{

	u32 old, new;
@@ -102,7 +101,6 @@ int ftrace_modify_call(struct dyn_ftrace *rec, unsigned long old_addr, unsigned 


	return ftrace_modify_code(pc, old, new, true);

}



#endif /* CONFIG_DYNAMIC_FTRACE_WITH_REGS */



int ftrace_update_ftrace_func(ftrace_func_t func)