Commit 815ac856 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: atomisp: atomisp_gmin_platform: check before use 



solve this smatch warning:
	drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c:842 gmin_v1p8_ctrl() warn: variable dereferenced before check 'gs' (see line 832)

By moving the check to happen before its usage.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent b2999af9

drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -817,6 +817,9 @@ static int gmin_v1p8_ctrl(struct v4l2_subdev *subdev, int on) 
	int ret;

	int ret;

	int value;

	int value;





	if (!gs || gs->v1p8_on == on)

		return 0;



	if (gs->v1p8_gpio >= 0) {

	if (gs->v1p8_gpio >= 0) {

		pr_info("atomisp_gmin_platform: 1.8v power on GPIO %d\n",

		pr_info("atomisp_gmin_platform: 1.8v power on GPIO %d\n",

			gs->v1p8_gpio);

			gs->v1p8_gpio);
@@ -827,8 +830,6 @@ static int gmin_v1p8_ctrl(struct v4l2_subdev *subdev, int on) 
			pr_err("V1P8 GPIO initialization failed\n");

			pr_err("V1P8 GPIO initialization failed\n");

	}

	}





	if (!gs || gs->v1p8_on == on)

		return 0;

	gs->v1p8_on = on;

	gs->v1p8_on = on;





	if (gs->v1p8_gpio >= 0)

	if (gs->v1p8_gpio >= 0)