Commit 814b6f91 authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: update the comment for submit_extent_page() 



Since commit 390ed29b ("btrfs: refactor submit_extent_page() to make
bio and its flag tracing easier"), we are using bio_ctrl structure to
replace some of arguments of submit_extent_page().

But unfortunately that commit didn't update the comment for
submit_extent_page(), thus some arguments are stale like:

- bio_ret
- mirror_num
  Those are all contained in bio_ctrl now.

- prev_bio_flags
  We no longer use this flag to determine if we can merge bios.

Update the comment for submit_extent_page() to keep it up-to-date.

Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent d6921739

fs/btrfs/extent_io.c

+5 −3
Original line number Diff line number Diff line
@@ -1548,11 +1548,13 @@ static int alloc_new_bio(struct btrfs_inode *inode, 
 * @size:	portion of page that we want to write to

 * @pg_offset:	offset of the new bio or to check whether we are adding

 *              a contiguous page to the previous one

 * @bio_ret:	must be valid pointer, newly allocated bio will be stored there

 * @end_io_func:     end_io callback for new bio

 * @mirror_num:	     desired mirror to read/write

 * @prev_bio_flags:  flags of previous bio to see if we can merge the current one

 * @compress_type:   compress type for current bio

 *

 * The will either add the page into the existing @bio_ctrl->bio, or allocate a

 * new one in @bio_ctrl->bio.

 * The mirror number for this IO should already be initizlied in

 * @bio_ctrl->mirror_num.

 */

static int submit_extent_page(blk_opf_t opf,

			      struct writeback_control *wbc,